search

cjekel / piecewise_linear_fit_py

fit piecewise linear data for a specified number of line segments
MIT License
300 stars 60 forks source link

Update SciPy #59

Closed bezineb5 closed 4 years ago

bezineb5 commented 4 years ago

It doesn't work with SciPy 1.1.0, so I updated this dependency. Version 1.2.3 is the latest to work with Python 2 (maybe it would be worth dropping Python 2 now)

cjekel commented 4 years ago

Hey thanks for the PR. I'm totally fine with upgrading the dependencies as you recommend, but I want to make sure we solve the issue.

I created a new environment with scipy==1.1.0 and numpy==1.16.5, then installed the latest pwlf. The tests passed, and I was able to run the examples without issues.

What version of numpy and pwlf were you using? What was the error message? I just want to make sure that scipy was indeed the issue.

I'll plan on supporting Python 2.7 as long as it doesn't require extra work to support. Eventually that day will come.

bezineb5 commented 4 years ago

Actually, I had the exact same issue as the one described here: https://github.com/cjekel/piecewise_linear_fit_py/issues/40

I just tried to revert to scipy 1.1.0 and I can reproduce the issue. I have numpy 1.17.4.

cjekel commented 4 years ago

Thanks much for the details in https://github.com/cjekel/piecewise_linear_fit_py/issues/40#issuecomment-581671908 !

If 1.2.0 fixes this issue on your end, do you mind changing the pr to that version? I just want to maximize the version availability.

bezineb5 commented 4 years ago

Done. By the way, thanks a lot for the library!

cjekel commented 4 years ago

I'm glad It's been useful for you. Thanks for pointing out the versioning problem and the explanation.