search

cjemorton / skipfish

Automatically exported from code.google.com/p/skipfish
Apache License 2.0
0 stars 0 forks source link

save_keywords() calls fdopen twice #73

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
One of those fdopen's is unnecessary (afaict):

database.c:1070

  fd = open((char*)fname, O_WRONLY | O_CREAT | O_EXCL, 0644);

  if (fd < 0 || !(out = fdopen(fd,"a"))) {
    WARN("Unable to save new wordlist to '%s'", fname);
    close(fd);
    return;
  }

  out = fdopen(fd, "w");

Original issue reported on code.google.com by n3npq....@gmail.com on 5 Jul 2010 at 1:09

GoogleCodeExporter commented 8 years ago 
Looks like, thanks :-) 

Fixed, will target it for the next release in a couple of days (since it does 
not seem to have any major side effects, I want to bundle it with some other 
tweaks).

/mz

Original comment by lcam...@gmail.com on 5 Jul 2010 at 1:18