search

cjiang2 / VDCNN

Implementation of Very Deep Convolutional Neural Network for Text Classification
171 stars 41 forks source link

confused about the embedding #13

Closed cailurus closed 3 years ago

cailurus commented 5 years ago

great work dude, sorry for my rude, I was just confused about the embedding layer in code

for my knowledge, it usually be Embedding(input_dim=$vocab_size, output_dim=$embedded_size, input_length=$input_size)

zhongzhh8 commented 5 years ago

I am confused too.Do you understand it now?

mmpang commented 4 years ago

I'm also confused about the argument of Embedding. Could @zonetrooper32 please explain why assign input_length to input_dim? Thanks a lot !

cjiang2 commented 3 years ago

I'm also confused about the argument of Embedding. Could @zonetrooper32 please explain why assign input_length to input_dim? Thanks a lot !

Correct embedding implementation is updated in main branch, along with Tensorflow 2 support.