search

cjiang2 / VDCNN

Implementation of Very Deep Convolutional Neural Network for Text Classification
171 stars 41 forks source link

Minor Bug #5

Closed athn-nik closed 6 years ago

athn-nik commented 6 years ago

ag news dataset test doesnt reach 1024 threshold but if you run the code for yahoo answers which reaches beyond 102 you'll get an error because you substitute character before checking for reaching 1024.The condition of reaching max sequence length should be on top of all!

cjiang2 commented 6 years ago

Thank you for pointing this out. I'll address this issue along with the updates for optional shortcut, which I'll finish testing soon. :)