search

cjihrig / credit-card

Credit card validation
MIT License
104 stars 22 forks source link

Uglify issue #28

Closed lancecarlson closed 8 years ago

lancecarlson commented 8 years ago

I'm still trying to track down the exact problem, but I'm running node 4.4.6 and I just tried to uglify your package and got an error. I think it was having issues parsing 'let', so I think I need to upgrade my node to 5 in order to actually uglify your code. Will it be a requirement to use node 5 in order to use your lib? if so, it should be indicated somewhere.

cjihrig commented 8 years ago

let is supported in Node v4. Also, we run v4 in our CI (see .travis.yml). Sounds like an uglify issue.

lancecarlson commented 8 years ago

FYI, you were right. Needed to use uglify on the harmony branch.