Closed arb closed 10 years ago
Editing the employee needs to update the Teams too. Currently, if you change someone's team, it's reflected on their profile, but if you go to that team's page, they aren't there. In a SQL world this wouldn't be a problem.
Also, can we place the Edit/Save button somewhere else on the page? Right now, it's creating an awkward gap of whitespace at the top of the profile. Maybe below the profile pic?
Shouldn't the members of a team be like a computed function rather than an additional datapoint that we have to maintain? I'm having issues trying to remove from one team and add to another. It just seems harder than it should be to do this.
Now that I think about it... the way this is, I would have to basically find every team that has person 123 in it's members and delete it from every team, and then put them into the new team they should be on.
Feel free to change the way team members are stored. I was planning on only letting a person be on a single team (which is stored with the employee data). The SQL way (aka the right way) would be to have a table that has two fields, employeeId and teamId. That would support a person being on multiple teams.
Updated @cjihrig. I would have rebased but the pull from master sort of screwed that up. I did roll all my commits for the changes today into two though so at least that's something.
Don't worry about rebasing and such. Once we get a "finish product" I plan to blow the commit history away so no one can see all the mistakes we've made :smiling_imp:
Seems to be working. Just some cleanup needed.
@cjihrig your move.
Finished simple employee inline editing. All of the fields that turn into text boxes should work. The team drop down should also function correctly. I was going to rebase but... I would have needed to go back way too far.