search

cjkrolak / ThermostatSupervisor

supervisor to detect and correct thermostat deviations
MIT License
0 stars 0 forks source link

low wifi signal strength shows N/A instead of weak status #720

Closed cjkrolak closed 10 months ago

cjkrolak commented 10 months ago

wifi strength added in #715 has a bug, status should be "weak" for < -70 dBm instead of "N/A", this issue may not be specific to blink.

querying select data for all zones:
Did not receive valid response from server.
zone: 0, name: 0, temp: -123456789.0, wifi strength: -123456789.0 dBm (N/A), battery voltage: -123456789.00 volts (ok)
Did not receive valid response from server.
zone: 1, name: 1, temp: 28.0, wifi strength: -64.0 dBm (ok), battery voltage: 1.66 volts (ok)
Did not receive valid response from server.
zone: 2, name: 2, temp: 28.0, wifi strength: -66.0 dBm (ok), battery voltage: 1.70 volts (ok)
Did not receive valid response from server.
zone: 3, name: 3, temp: 28.0, wifi strength: -62.0 dBm (ok), battery voltage: 1.68 volts (ok)
Did not receive valid response from server.
zone: 4, name: 4, temp: 30.0, wifi strength: -49.0 dBm (ok), battery voltage: 1.69 volts (ok)
Did not receive valid response from server.
zone: 5, name: 5, temp: 33.0, wifi strength: -70.0 dBm (ok), battery voltage: 1.46 volts (ok)
Did not receive valid response from server.
zone: 6, name: 6, temp: 28.0, wifi strength: -77.0 dBm (N/A), battery voltage: 1.65 volts (ok)
Did not receive valid response from server.
cjkrolak commented 10 months ago

root cause is that BOGUS_BOOL is set to False, so function can't distinguish between BOGUS_BOOL and False results. Fix is to define BOGUS_BOOL as None instead, need to do full testing to understand if this change impacts other functions.