search

cjlin1 / liblinear

LIBLINEAR -- A Library for Large Linear Classification
https://www.csie.ntu.edu.tw/~cjlin/liblinear/
BSD 3-Clause "New" or "Revised" License
1.01k stars 342 forks source link

On macOS extension should be .dylib #85

Closed barracuda156 closed 1 year ago

barracuda156 commented 1 year ago

It should install as liblinear.dylib instead.

cjlin1 commented 1 year ago

can you elaborate more?

barracuda156 commented 1 year ago

Standard shared library extension on macOS is .dylib. While .so is used in some specific context, it is not how shared libraries are normally installed.

cjlin1 commented 1 year ago

Thanks. Because .so still works and in our code we have something like

try:
    if sys.platform == 'win32':
        libsvm = CDLL(path.join(dirname, r'..\..\windows\libsvm.dll'))
    else:
        libsvm = CDLL(path.join(dirname, '../../libsvm.so.3'))

we think it may be better to keep using .so for now.