cjlin1 / libsvm

LIBSVM -- A Library for Support Vector Machines
https://www.csie.ntu.edu.tw/~cjlin/libsvm/
BSD 3-Clause "New" or "Revised" License
4.52k stars 1.64k forks source link

Linux wheel support in github workflow #188

Closed naetherm closed 10 months ago

naetherm commented 1 year ago

Hello, I am wondering if there are plans on adding linux support in the provided wheel.yml file? Maybe this is related to @yxliu-ntu who initially added the github actions support.

Are there also plans in automatically pushing created wheels to PyPi?

Sinacam commented 1 year ago

Hello, I am wondering if there are plans on adding linux support in the provided wheel.yml file?

We're apprehensive of adding Linux binaries due to the multitudes of Linux distros and our lack of testing on them. May I ask if there are particular difficulties in installing a source distribution? We will include MacOS binaries in upcoming releases.

Are there also plans in automatically pushing created wheels to PyPi?

If you're asking about nightly builds, we currently only plan to push wheels on version updates. If you're asking about continuous deployment, our (internal) tests are somewhat finicky and we aren't currently automating that.

betaboon commented 1 year ago

@Sinacam we're using libsvm-official in our ci-pipelines to build container-images et al. if wheels for linux would be available that would drastically improve our buildtimes (and save costs and energy obviously)

for now we are storing linux-wheels on our own package-registry, but it would be preferable to have them available on pypi.

190 already has all the ci-changes required to do proper matrix-build targetting windows+linux+macos.

looking forward to hearing fro myou.

Sinacam commented 1 year ago

Sorry for the late reply. We have an private repo for development and have already accepted the ci-changes for MacOS, but they won't be available until the next release. Unfortunately, since we currently can't guarantee the correctness of Linux binaries, we won't be providing them.

betaboon commented 1 year ago

@Sinacam what would you need to feel like you can guarantee the correctness? what's the path forward here?

betaboon commented 1 year ago

@Sinacam any update on this?

Sinacam commented 11 months ago

@betaboon I'm sorry for the large delay, I thought I got back to you already and completely forgot that I didn't.

@Sinacam what would you need to feel like you can guarantee the correctness? what's the path forward here?

Our tests have large manual elements in them and performing tests on different platforms are tedious. In an ideal world, we will have complete automated test suites with perfect accuracy, but we're a school research team so this type of engineering effort is hard to justify and hard to maintain long term as members come and go. So unfortunately, no plans to provide Linux binaries.