search

cjlotz / Xamarin.Plugins

Cross platform Xamarin Plugins
MIT License
113 stars 56 forks source link

Question: Need for "MessageRequest" classes? #5

Closed jamesmontemagno closed 9 years ago

jamesmontemagno commented 9 years ago

I was curious about the logic here. Seems like some overhead to create these in memory. Can't they just be parameters? This would make more sense to me.

cjlotz commented 9 years ago

One can probably drop the SmsMessageRequest class as there is not much content in there and you can't expand the api much later on. The EmailMessageRequest was to provide a stable api for future updates (i.e. adding Attachments, sending through HTML content etc.) I was also thinking about creating something like an EmailBuilder class in future to provide a fluent interface for constructing the Email.

jamesmontemagno commented 9 years ago

Gotcha, yeah I think the Sms one could be dropped since it is similar to the phone one. Makes a bit more sense to me.