search

cjmamo / kafka-web-console

A web console for Apache Kafka (retired)
Apache License 2.0
762 stars 246 forks source link

Fixes #36. Fixes #30. #40

Open ibanner56 opened 9 years ago

ibanner56 commented 9 years ago

There's been an issue with web-console-consumer-XXXX nodes not being deleted after you leave a topic's page. I changed how the function was calling delete on the nodes so that it doesn't trigger an eventThread shutdown prior to the delete completing on the parent node. Now you don't end up with undeleted nodes in zookeeper.

ibanner56 commented 9 years ago

Not all the client connections to kafka were being closed, only the one that was being used. Changed the client closing line (now line 80) to close all the clients that are being opened in getPartitionsLogSize.

ches commented 9 years ago

Six months and no review from maintainer? Thanks Isaac, will be testing your fork shortly.