search

cjmanca / plex-credits-detect

Augments plex's built in intro detection, additionally detecting credits.
MIT License
114 stars 5 forks source link

Uninstallation / Removal of inserted markers into the DB #64

Open Starblaster100 opened 1 year ago

Starblaster100 commented 1 year ago

Firstly, I wanted to say a massive thank you to you for creating this project. Like many others have experienced, this has been an amazing stop gap in the plex product offering until plex added this natively themselves, and I cannot thank you enough for that - countless hours must have gone into developing and fine tuning this for the community <3

I wanted to open a discussion around the best way to go about uninstalling plex-credits-detect, specially around how to remove the markers that were added to the DB. Im not sure if they might conflict with the new credit markers that plex will be adding in, or if they can live side by side with each other?

FWIW, I am running plex-credits-detect through your docker image, cjmanca/plex-credits-detect:main

Any guidance you can provide would be greatly appreciated!

cjmanca commented 1 year ago

This shouldn't be necessary. Every time Plex modifies the markers, it replaces all existing markers for that season. So when it adds it's own credit markers, it'll naturally remove the ones that this tool added when doing so.

Bussterj commented 1 year ago

I have some old shows that still have "Skip Intro" at the end and doesn't transition to the smaller window and show next episode like the new built in skip credits feature. Is there anyway of fixing this as Plex's own detection hasn't overridden yours as mentioned above

cjmanca commented 1 year ago

All the shows which have been detected as a credits section by plex for me have overwritten my markers with theirs so far in my database.

There are a couple of reasons I can think of as to why it may not have for you:

  1. Plex hasn't gotten around to detecting credits for that show. I'm sure it'll take weeks or months for most decent sized libraries to be fully scanned.
  2. Plex's credits detection didn't find any credits, so it didn't replace the credit markers.
  3. You're still running the "plex-credits-detect" utility, and it's re-adding the previous markers after plex replaces them.