[Android Bootcamp] Image Finder Week 2 - Review my app #2

[cjmartin2]

My app is complete for the second project submission.

How many hours: 10-12

Optional User Stories:

• The only optional user story is search in the Action Bar. For some reason, this is firing the onQueryTextSubmit twice. I did not dig into this.

/cc @nesquena @timothy1ee

[nesquena]

:+1: nice work Craig. A few notes after checking out the code:

• Consider better organizing your source files
• Properly reused the single base method in search activity to fetch results for both initial load and the pagination
• Nice to see you added the search to the ActionBar!
• Properly used spinners (with populated values) to allow users to select filters
• Properly send and receive relevant filters using a bundle to pass data between activities
• One thing to consider is rather than sending and returning all the filter values separately as keys, might have introduced a serializable model (i.e SearchFilters.java) representing all the filters which was passed back and forth in the activities in the bundle
• Consider adding the ability to share an image. This is an important learning for this assignment even though it's optional.

Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.