[Android Bootcamp] Twitter Client Week 4 - Review my app #4

[cjmartin2]

My app is not currently complete for this project submission. I expect to be complete the required stories within the next hour. I am just trying to get my user profile timeline fragment functioning correctly for viewing other users profiles. Will update this issue when final code is pushed for required user stories.

How many hours: 12

Hoping to work on optional user stories & polish later this week.

/cc @nesquena @timothy1ee

[nesquena]

I expect to be complete the required stories within the next hour.

Ping again here when this is complete Craig. Hard cutoff for extension is midnight, so I hope you are able to complete by then, sounds like you will be able to.

[cjmartin2]

Alright, final commit is in. I thought I was doing something fundamentally wrong, but it was the JSONObject versus JSONArray issue that you pointed out in the Google Group.

Kept tinkering with things because I assumed it was an issue with inflating the fragment (based on the error). But when I implemented the onFailure method and it wasn't getting hit either, I immediately remembered the messages from the Google Group. Stupid mistake.

[nesquena]

:+1: nice work overall. A few notes after checking out the code:

• Good to see some skinning with styles
• Consider adding progress bars to your app whenever a network request goes out
• For tabs, try following this approach for cleaner tab listeners and better memory management.
• Good to see you properly communicated the user to the user timeline fragment from the profile activity.
• Nicely done architecting the fragments (base class and extension classes) such that you put as much code and logic as possible in the base class and then used abstract methods to define only the specific behavior where they differ! Although could have even less duplication.
• Consider adding local persistence of tweets by using ActiveAndroid in the Tweet and User. See the persistence guide and this other guide for more details.

Here's a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

This week (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 and week 7 we will be covering a few important intermediate topics such as more about styling and animation as well as testing.

Following the bootcamp (May 12th), we are going to have a demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group projects that you all have built. We are going to help however we can over the next few weeks to get the team project apps in shape for that.

Alright, final commit is in. I thought I was doing something fundamentally wrong, but it was the JSONObject versus JSONArray issue that you pointed out in the Google Group.

Ah yeah, that one can be a painful gotcha. Glad you figured it out!