search

cjmartin2 / OneWarmCoat-android

One Warm Coat Android app
3 stars 0 forks source link

volunteer sees pickup request intermittently #38

Closed tam07 closed 10 years ago

tam07 commented 10 years ago
  1. volunteer accepts pickup request on the map.
  2. the marker disappears
  3. donate something as a volunteer
  4. go back to pickup requests
  5. original pickup request marker appears again,
cjmartin2 commented 10 years ago

2 is expected, because once the volunteer accepts a pickup, the pickup request is in a pending state, so should be removed from the map.

tam07 commented 10 years ago

so upon revisiting the fragment he shouldn't see it anymore.

cjmartin2 commented 10 years ago

Right. Also, in theory it should be hooked up to remove the individual marker, when the volunteer clicks Accept. Or if we can't easily get a reference to 1 marker, just reload all the markers onAccept.

aphexcx commented 10 years ago

How do you guys want to handle the following: after the volunteer accepts a request, he is listed as the pendingVolunteer for that request. But the user still needs to confirm they are available. When they confirm, how should the request change in its back end representation?

cjmartin2 commented 10 years ago

Shouldn't they then be considered a confirmed volunteer?

tam07 commented 10 years ago

it looks like that column was removed.

aphexcx commented 10 years ago

we could have a confirmedVolunteer column, but then really the same volunteer should show up in both columns. maybe just have a boolean column: Ready. a pickup is Ready when a user confirms the coats are ready for pickup. thoughts?

cjmartin2 commented 10 years ago

Nope, there is definitely a column available for confirmedValet. Check the CharityUserHelper class. A column doesn't show up until there is an entry saved in it. - Craig Martin ----------------------------Sent from my BlackBerry 10 smartphone. From: AfikSent: Friday, May 9, 2014 9:24 PMTo: cjmartin2/OneWarmCoat-androidReply To: cjmartin2/OneWarmCoat-androidCc: Craig MartinSubject: Re: [OneWarmCoat-android] volunteer sees pickup request intermittently (#38)we could have a confirmedVolunteer column, but then really the same volunteer should show up in both columns. maybe just have a boolean column: Ready. a pickup is Ready when a user confirms the coats are ready for pickup. thoughts?

—Reply to this email directly or view it on GitHub.

cjmartin2 commented 10 years ago

Marker now gets cleaned up as soon as volunteer confirms the pickup.