search

cjmurph / PmsService

Plex Media Server service wrapper for windows
MIT License
514 stars 58 forks source link

PmsMonitor: refactor update detection #80

Closed chrisdecker08 closed 1 year ago

chrisdecker08 commented 1 year ago

Refactored to no longer rely on log monitoring to detect when PMS is updating and to instead checks if the PMS Updater Service Launcher process is running.

This is my first time writing in C# so please keep that in mind when reviewing

cjmurph commented 1 year ago

coding style looks fine. Have you tested it with success?

chrisdecker08 commented 1 year ago

this has been tested by both myself and the QA person who brought it to my attention. it should be noted that while I know this is compatible with PMS versions in the last 2 years or so, I'm not familiar enough with the history to guarantee much more than that. Its possible it will be compatible all the way back but i'm not sure.