search

cjnaz / rclonesync-V2

A Bidirectional Cloud Sync Utility using rclone
MIT License
355 stars 39 forks source link

Make Path1 and Path2 named arguments #48

Closed 3ter closed 4 years ago

3ter commented 4 years ago

I'd propose to change the argument parsing for Path1 and Path2: In the case of first-sync at least one of them should need to be marked with --source or something similar, to reduce confusion of what path actually "wins".

Thanks a lot for bringing that bidirectional rclone sync to live @cjnaz <3.

cjnaz commented 4 years ago

Thanks @3ter for the feedback and support..

As you may have already figured out, the not-executed-deletes in your original post are not real - they are an artifact of the --first-sync and --dry-run. See --dry-run oddity in the README.md.

The net result of a --first-sync (without --dry-run) will always be the superset of both sides, with the only exception due to the finally executed rclone sync Path1 Path2 if rclone itself detects a difference between the Path1 and Path2 versions of a file - Path1 always wins even if its the older file. See --first-sync in the README.md.

So in actuality, there is no "source/destination" or "master/slave" dependency in --first-sync or normal (non --first-sync) modes.

I'll take the liberty of closing this issue, but your further comments are welcome.

3ter commented 4 years ago

You've got it completely right, @cjnaz. Thanks for clarifying it up further!