search

cjntaylor / node-cmake

CMake-based build system for node.js native modules
ISC License
78 stars 20 forks source link

convert NODEJS_LINK_FLAGS to space separated string #26

Closed stixx200 closed 7 years ago

gpean commented 7 years ago

I think we also need to quote ${NODEJS_LINK_FLAGS} when we use it in set_target_properties, otherwise I'm getting this error on ubuntu because NODEJS_LINK_FLAGS happens to be empty:

CMake Error at node_modules/node-cmake/NodeJS.cmake:610 (set_target_properties):
  set_target_properties called with incorrect number of arguments.
cjntaylor commented 7 years ago

Thank you for the pull request. I decided to tackle this a different way but I really appreciate the input. Please update to 2.3.1 and let me know if you're still having issues.

stixx200 commented 7 years ago

Thanks for fast response. I still have issues with the linker flags. Now it seems that all linker flags are appended into one string. The problem is, that there are no spaces between the flags. Something like "${NODEJS_LINK_FLAG} " would help.

cjntaylor commented 7 years ago

Fixed in 2.3.2