search

cjohansen / juicer

A command line tool for JavaScript and CSS developers
630 stars 47 forks source link

add csslint #35

Closed stereobooster closed 7 years ago

stereobooster commented 13 years ago

https://github.com/stubbornella/csslint I started it at https://github.com/stereobooster/juicer. But I feel like the refactoring is needed.

frankpf commented 13 years ago

I don't think that should be included as a default. CSS Lint is an extremely optionated tool based on principles of OOCSS, which many don't agree.

stereobooster commented 13 years ago

Only 4 rules from 16 have something in share with OOCSS. All other is common. For example: Remove empty rules, Use correct properties for a display and so on. You can turn of rules which you don't agree.

cjohansen commented 13 years ago

I don't see a problem with including it as a voluntary binary. Quite the contrary, would be useful in my opinion.

stereobooster: What do you want to refactor? I think it looks pretty good, but it's missing two things: a hook into the binary (which does need refactoring...) and some tests :) What do you think?

stereobooster commented 13 years ago

stereobooster: What do you want to refactor?

I begin to add csslint and find myself copy/pasting code, for me it's a sign... Take a look

cjohansen commented 13 years ago

Ah, right. Want to give it a shot? I'd suggest extracting a Juicer::RhinoBinary that includes Juicer::Binary, but removes the duplication between the Rhino binaries.

stereobooster commented 13 years ago

Ah, right. Want to give it a shot?

I will try if i have time. But I can’t promise anything.