cjohansen / portfolio

Eclipse Public License 1.0
236 stars 14 forks source link

Why are the overflows `scroll` rather than `auto`? #8

Closed elken closed 1 year ago

elken commented 1 year ago

Love portfolio! Working on migrating devcards over to it at work atm and it's an absolute joy in comparison.

One thing I have noticed is the various containers are marked as overflow: scroll rather than overflow: auto which leads to a collection of scrollbar arrows at the bottom, is there a specific reason for this? image

cjohansen commented 1 year ago

Thanks, very glad to hear you're enjoying it :)

Well, this doesn't look so great. The original idea was that most containers should have overflow: hidden and just have overflow: scroll on the scene to allow big scenes to scroll when necessary. But there should really only be one container with this setting. I've been a little back and forth on how to implement the grid layout, so I'll have a look to see if I can clean it up a little - and maybe auto works better.

elken commented 1 year ago

Just saw the ninja edit as I was writing my comment :P

I think so, it'll only add in the scrollbar when there's content to scroll

cjohansen commented 1 year ago

Haha, yeah, I was a little quick 😅 Will give it a shot.

cjohansen commented 1 year ago

If you're able to use Portfolio from git, could you try the current head? I'll use it a little myself before I cut a release, just to make sure I didn't break anything.

elken commented 1 year ago

If you're able to use Portfolio from git, could you try the current head? I'll use it a little myself before I cut a release, just to make sure I didn't break anything.

Will try it out now

elken commented 1 year ago

Yes that seems much nicer! Free of scrollbars and they show up much rarer now.

Thanks for a swift resolution :)

cjohansen commented 1 year ago

Cool 👍