search

cjohansen / sinon-qunit

A small Sinon.JS adapter for QUnit that provides automatic sandboxing of mocks and stubs
http://cjohansen.no/sinon/qunit
Other
26 stars 12 forks source link

useFakeTimers enabled by default? #6

Closed goligo closed 11 years ago

goligo commented 11 years ago

When embedding sinon-qunit.js, all usage of setTimeout in existing tests stops working, as the sinon-qunit.js enables fake timers by default. I don't see a good reason for doing so, I would prefer to chose to use fake timers when I need to.

cjohansen commented 11 years ago

It would be a breaking change, but I tend to agree. PR it? :)

goligo commented 11 years ago

Fixed.