cjohansen / sinon-qunit

A small Sinon.JS adapter for QUnit that provides automatic sandboxing of mocks and stubs
http://cjohansen.no/sinon/qunit
Other
26 stars 12 forks source link

Doesnt clean up with async tests #8

Open giulianob opened 11 years ago

giulianob commented 11 years ago

Async tests might return immediately but in reality the tests haven't finished yet. This makes it so the adapter doesnt clean up the sandbox properly. These guys have already fixed it: https://github.com/jfromaniello/jmail/blob/master/scripts/Tests/sinon-qunit-1.0.0.js

lijunle commented 11 years ago

Thanks to giulianob!

With sinon-qunit, async test in QUnit doesn't work properly. And the version of sinon-qunit you provided solve this issue.

JeffFaer commented 10 years ago

:+1:

jj09 commented 9 years ago

Shouldn't this be PR?