Token-blind comment/uncomment algorithms to use when buffer has unprocessed changes?

cjohansson / emacs-phps-mode

Emacs major mode for PHP with code intelligence

GNU General Public License v3.0

35 stars 2 forks source link

Token-blind comment/uncomment algorithms to use when buffer has unprocessed changes? #35

Closed cjohansson closed 2 years ago

cjohansson commented 3 years ago

I added a fix today that forced synchronously runs lexical analysis on buffer before running the comment / uncomment algorithm in case there are unprocessed changes in buffer

cjohansson commented 3 years ago

The problem with current setup is that if you have a large file, lexical analysis is slow and when it's done synchronously it freezes the editor, another issue seems that lexical-analysis is run twice in this case

cjohansson commented 2 years ago

I don't think this is an issue