search

cjohansson / emacs-ssh-deploy

A deployment plugin via Tramp for Emacs.
GNU General Public License v3.0
154 stars 6 forks source link

'display-warning throws 'wrong-type-argument error #39

Closed articuluxe closed 6 years ago

articuluxe commented 6 years ago

When something goes wrong, ssh-deploy is calling 'display-warning with a string, instead of a symbol, as its first argument. I had to change it to the symbol 'ssh-deploy rather than "ssh-deploy".

Debugger entered--Lisp error: (wrong-type-argument listp "ssh-deploy")
  warning-suppress-p("ssh-deploy" ((undo discard-info)))
  display-warning("ssh-deploy" "This is a warning")

I am running emacs 24 and 25.

cjohansson commented 6 years ago

Ah, I haven’t stumbled upon that. Do you know if Emacs 26 and 27 supports using a symbol? It probably does, since it should be backwards compatible. You can open a pull request for this if you want.

cjohansson commented 6 years ago

I made a commit for it now, hope it resolves the issue for you

articuluxe commented 6 years ago

Looks much better thank you, and thanks for the package.