search

cjprecord / editra-plugins

Automatically exported from code.google.com/p/editra-plugins
0 stars 0 forks source link

MacroLauncher Release Prep #109

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I did a quick review, cleanup, and some tweaks to the plugin.

I noted some items that need to be checked out search for TODO:CJP in the
text. I will likely add more as I am able to test and review the code more
thoroughly.

Please use this ticket for discussing TODO items. Once I close this I will
make the plugin available for release.

Cody

Original issue reported on code.google.com by CodyPrec...@gmail.com on 23 May 2009 at 12:53

GoogleCodeExporter commented 9 years ago 
Thanks, I uploaded new version - with two TODOs solved

there remains this one, it is in the OnDelMacro - I am basically trying to 
close the
macro before deleting it (if it is opened)

                # TODO:CJP what are you trying to do here? I am sure there is a
better way

                # Cycle through the opened pages and see if the macro is there
                # If yes, I would like to set its modify status to False so that
                # Editra is not warning user, Perhaps I better save&close it?
                ctrls = nbook.GetTextControls()
                for ctrl in ctrls:
                    if source == ctrl.GetFileName():
                        index = nbook.GetPageIndex(ctrl)
                        #HACK I dont know how to set Modify = False for the stc_ctrl
                        if ctrl.GetModify():
                            evt = wx.MenuEvent(wx.wxEVT_COMMAND_MENU_SELECTED,
ed_glob.ID_SAVE)
                            self.GetTopLevelParent().OnSave(evt)
                        nbook.SetSelection(index)
                        nbook.ClosePage()

                ....here macro is deleted from the filesystem

Original comment by roman.ch...@gmail.com on 23 May 2009 at 12:47

GoogleCodeExporter commented 9 years ago 
Ok,

So you want to save it so it can silently be closed?

You can instead call

ctrl.SetSavePoint()

to clear the modified flag.

Cody

Original comment by CodyPrec...@gmail.com on 24 May 2009 at 12:53

GoogleCodeExporter commented 9 years ago 
thanks for the tip, changed. I believe the todo's from here are solved (but I 
have
yet to close other tickets)

Original comment by roman.ch...@gmail.com on 26 May 2009 at 6:24

GoogleCodeExporter commented 9 years ago 
Hello,
I think the issues have been fixed now (besides label/type rename)

roman

Original comment by roman.ch...@gmail.com on 26 May 2009 at 8:59

GoogleCodeExporter commented 9 years ago 
ok,

I will play around with it a little more of the next couple days and if all 
looks
good will add it to the plugin manager for download.

cody

Original comment by CodyPrec...@gmail.com on 27 May 2009 at 1:53

GoogleCodeExporter commented 9 years ago 
Ok, everything seems to be working pretty well. Didn't get any more crashes in 
the
other superficial tests that I did this weekend.

If everything looks in order, send me an email and I will bundle the eggs and 
enable
their detection on the pluginmanager on the server.

cody

Original comment by CodyPrec...@gmail.com on 1 Jun 2009 at 4:44