search

cjprecord / editra-plugins

Automatically exported from code.google.com/p/editra-plugins
0 stars 0 forks source link

Revision History Window Issues #25

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I have been using the Revision History Window allot lately and have noticed
some a number of problems with it. I can probably put sometime into fixing
some of them here is a listing incase you get a chance to get to them first.

#----------------------------

ISSUE 1:

Category: Trivial

The button for comparing revisions should be disabled when there is no item
selected in the ListCtrl. Also see ISSUE 4 as it is partially related.

#----------------------------

ISSUE 2:

Category: Fatal

Click on and highlight one item in the list control then click on the
button to see diff. The diff will show and the editor will crash shortly
after. It seems to work fine when 2 items are selected and does not produce
a crash.

#-----------------------------

ISSUE 3:

Category: UI

After opening a diff by selecting 2 items in the history window the
progress indicator in the status bar seems to run indefinitely until the
window is destroyed.

#-----------------------------

ISSUE 4:

Category: Trivial / Behavior

The default text that shows up in the button when the dialog is open and no
items are selected is a little misleading. I am guessing it means to
compare the current local copy to the repository version but visually its
hard to realize what is being compared, I think that if this dialog is
being used that a selection should be required in the list. This issue is I
guess partly just an opinion so let me know what you think.

#-----------------------------

ISSUE 5: 

Category: Trivial / UI

Right clicking on the history window causes the popup menu that is used in
the ProjectsPane to be shown. I am guessing that since that pane is the
parent window EVT_CONTEXT_MENU must be a command event that is propagating
to the parents event handler. A fix might be to bind the event to the
history window and then just swallow it the history windows event handler.

Original issue reported on code.google.com by CodyPrec...@gmail.com on 15 Oct 2007 at 9:24

GoogleCodeExporter commented 9 years ago 
I checked in a fixes for issues 1, 4, and 5 listed above.

After fixing these issues I am no longer able to reproduce 2 and 3 so it is 
possible
that they were fixed indirectly by these and possibly some other recent changes 
in
the source control code.

I would like to have another set of eyes do a quick look before closing this so 
when
you get a chance please test the latest svn revision on you machine and if it 
looks
good feel free to close this issue.

Original comment by CodyPrec...@gmail.com on 18 Oct 2007 at 3:42

GoogleCodeExporter commented 9 years ago 
Here is what I'm seeing now.  If I try to diff two revisions, I don't get 
anything.  The status bar runs for a while, 
but the diffing program never comes up.  Also, when you select something then 
de-select it, the "Compare 
Revisions" button does not get disabled again.

Original comment by Kevin.Da...@gmail.com on 20 Oct 2007 at 7:25

GoogleCodeExporter commented 9 years ago 
Just checked in a fix for the button disabling issue

When I try to diff two revisions the diff program comes up fine on my machine. 
Are
you sure that the svn/cvs commands aren't failing because of network issues 
ect..
when trying to do the diff?

Original comment by CodyPrec...@gmail.com on 21 Oct 2007 at 12:26

GoogleCodeExporter commented 9 years ago 
It looks like the terminal plugin was interfering with the diffing subprocess.  
When I turned of the terminal, it 
started working again.

Original comment by Kevin.Da...@gmail.com on 21 Oct 2007 at 4:15

GoogleCodeExporter commented 9 years ago 
Ok good,

Can we consider this closed then?

Original comment by CodyPrec...@gmail.com on 21 Oct 2007 at 4:22

GoogleCodeExporter commented 9 years ago 
It looks good to me.

Original comment by Kevin.Da...@gmail.com on 21 Oct 2007 at 2:42

GoogleCodeExporter commented 9 years ago

Original comment by CodyPrec...@gmail.com on 21 Oct 2007 at 9:56

GoogleCodeExporter commented 9 years ago 
Move old 'fixed' issues to verified

Original comment by CodyPrec...@gmail.com on 3 Feb 2009 at 8:18