search

cjr1983 / libyuv

Automatically exported from code.google.com/p/libyuv
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

convert.cc:946:5: error: use of undeclared identifier 'RGB24ToARGBRow' #459

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Filing a bug report for someone else so it can be tracked.
Someone had a bad build flag and ran into:

INFO: From Compiling third_party/libyuv/files/source/convert.cc:
third_party/libyuv/files/source/convert.cc:946:5: error: use of undeclared 
identifier 'RGB24ToARGBRow'; did you mean 'RGB24ToARGBRow_C'?
   RGB24ToARGBRow = RGB24ToARGBRow_Any_SSSE3;
   ^~~~~~~~~~~~~~
   RGB24ToARGBRow_C

We resolved eventually by removing that bad flag, but I *think*, and I may be 
completely wrong here, there is a bug in that module.

...third_party/libyuv/files/source/convert.cc&l=946

This line is trying to set RGB24ToARGBRow when HAS_RGB24TOARGBROW_SSSE3, but 
that variable is only defined if !HAS_RGB24TOYROW_NEON.  Shouldn't you either 
declare RGB24ToARGBRow unconditionally or set it at L.946 after checking 
!HAS_RGB24TOYROW_NEON?

Original issue reported on code.google.com by fbarch...@google.com on 25 Jun 2015 at 6:55

GoogleCodeExporter commented 9 years ago 
This error only occurs if you attempt to enable both NEON and SSE2?  Not a 
valid configuration.

Original comment by fbarch...@google.com on 26 Jun 2015 at 9:45

GoogleCodeExporter commented 9 years ago 
fixed in r1442

Original comment by fbarch...@google.com on 30 Jun 2015 at 6:25