search

cjsaylor / atom-irc

[Not maintained] IRC client that works inside of Atom.io editor.
https://atom.io/packages/irc
MIT License
36 stars 7 forks source link

Links in messages #23

Closed aaronholla closed 9 years ago

aaronholla commented 9 years ago

This is in response to issue #22

Simple proof of concept, tested in atom running in dev mode. Uses Autolinker.js as a dependency. Works with multiple urls if the message is text or html.

Needs to be expanded more, as i said its just a proof of concept. My code isn't that great needs to be cleaned up, would also be nice to have a toggle on the settings page to be able to disable links.

cjsaylor commented 9 years ago

@aaronholla I like the idea, however we'll need to fix up this PR in order to get it in.

aaronholla commented 9 years ago

I had a slight bug with developer mode of atom where my settings where stuck. I couldn't get it to fix i tried window:reload and even unlinking and linking the dev package again. If you could double check that everything still works as intended that'd be great. Thanks.

cjsaylor commented 9 years ago

I'll give it a whirl.

cjsaylor commented 9 years ago

@aaronholla It seems to be working well for me. I'll give it until Monday if you want to do any additional cleanup, and then merge it in.

:+1:

aaronholla commented 9 years ago

Okay this is good to merge now. :grinning:

cjsaylor commented 9 years ago

Thanks, I tagged this in v0.3.1. It should be available in normal mode now.

aaronholla commented 9 years ago

Awesome! I also started working on being able to toggle join messages. Will also give connect and disconnect messages. I'll start a pull request for it.