Fixes #56 - binary compatibility with Undertow 1.3.x

cjstehno / ersatz

🤖 A simulated HTTP server for testing client code with configurable responses.

https://cjstehno.github.io/ersatz

Apache License 2.0

47 stars 5 forks source link

Fixes #56 - binary compatibility with Undertow 1.3.x #57

Closed musketyr closed 7 years ago

coveralls commented 7 years ago

Coverage increased (+0.03%) to 92.733% when pulling e4c4b5c2ac610b32827010425459a7e770856125 on musketyr:spring-boot-compatibility into b2c49e93c5311f682c972bc01e82d5284261c601 on cjstehno:master.

coveralls commented 7 years ago

Coverage increased (+0.03%) to 92.733% when pulling fe3f26988fb653d73338e39bcd1264fd417470d6 on musketyr:spring-boot-compatibility into b2c49e93c5311f682c972bc01e82d5284261c601 on cjstehno:master.

cjstehno commented 7 years ago

Hmm... I don't really like the system property injection to determine the version being used. My understanding is that the way I get the actual port is not supported in 1.3, but only 1.4? I don't think there is any real reason I cannot just backdate the library I use to 1.3 but I will have to make sure I am not losing any features.

I wonder if the gradle fuzzy version range support would help here combined with with your fix... just look for 1.3+ - not sure if that would take what you have or still just download the latest available.

Have to think about this one for a bit. Is this a showstopper for you?

cjstehno commented 7 years ago

Also, thanks for the pull request!

musketyr commented 7 years ago

Yes, this was a show stopper for me. I had to use Undertow directly 😞 I'm cool with the other solution you've suggested so I'm closing this one in favour of the simpler solution (downgrade to 1.3.15 of the whole library).

cjstehno commented 7 years ago

I will cut a release with this fix today.

musketyr commented 7 years ago

Fantastic!

cjstehno commented 7 years ago

I just woke up so it will be a few hours ;-)