search

cjstehno / ersatz

đŸ€– A simulated HTTP server for testing client code with configurable responses.
https://cjstehno.github.io/ersatz
Apache License 2.0
47 stars 5 forks source link

let `ErsatzServer` implement `Closable` #94

Closed musketyr closed 6 years ago

musketyr commented 6 years ago

to be able to use @AutoCleanup without specifying the close method name

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.007%) to 93.868% when pulling 97042657cec719a4c0f693dde32c74024111a48e on musketyr:master into b478583a73259c0563748d2485ad979e53949067 on cjstehno:master.

cjstehno commented 6 years ago

Thanks. Not sure why I never thought of that. ;-)

cjstehno commented 6 years ago

Can you merge this into the development branch instead, please.

musketyr commented 6 years ago

it looks weird now. can @cjstehno maybe can you cherry pick instead? the changes are trivial

cjstehno commented 6 years ago

Sure. I am going to change my branch management strategy with this release too. :-)

cjstehno commented 6 years ago

I have patched this into the 1.7.0 release code. Thanks.

musketyr commented 6 years ago

Thank you as well

Dne ne 15. čvc 2018 18:17 uĆŸivatel Christopher J. Stehno < notifications@github.com> napsal:

Closed #94 https://github.com/cjstehno/ersatz/pull/94.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cjstehno/ersatz/pull/94#event-1734261888, or mute the thread https://github.com/notifications/unsubscribe-auth/AAoTtb6fGr_fDsUUdk_QXazCfQA0ZL8qks5uG2sAgaJpZM4VMaM4 .