search

cjvanlissa / tidySEM

55 stars 7 forks source link

Support geom_textpath in plotting #69

Open LukasWallrich opened 1 year ago

LukasWallrich commented 1 year ago

Thanks for this fantastic package! One aspect that I was struggling with was label placement - until I came across the geomtextpath-package. If I use that instead of geom_path for the straight paths inside .plot_edges_internal here, I get tidier charts - such as the one below. I have implemented this in my fork and wanted to propose it here.

If that is of interest, I'd be happy to submit a PR ... though I would appreciate some guidance where to best place the option to choose whether to use this, I'm a bit unclear how such parameters are best passed here.

image

cjvanlissa commented 1 year ago

Dear Lukas, thank you for this suggestion! Some questions though:

Are both the straight and curved paths above using geom_textpath()? And can we have arrows on these paths? And would it make sense to replace geom_path everywhere instead of making it optional? And, could you share a before as well as after pic?

cjvanlissa commented 1 year ago

@LukasWallrich any update on this?