Closed bmkramer closed 2 years ago
Dear Bianca, I will change Step 4 due to GitHub's changed policy.
Step 6 is necessary, otherwise they will not have a valid git user and all git-related functions will fail. Overwrite = FALSE just does nothing, it's to ensure that our package tests don't change people's git users all around the world.
Hi Caspar, thanks for your reply.
Re: step 6: sure, but if a user has already set their git credentials, why is there a need to overwrite them in this step? (sorry if I'm being dense here ;)
This is a tutorial for starting from scratch; as it says in the intro, if a user already has some of this software installed, they can skip those steps.
But given the fact that not having a git user was one of the most common problems in workshops pre-worcs, I don't think it's wise to remove this step.
In going over the setup vignette in preparation for the WORCS workshop, I came across two points:
I would suggest not to include this step in the installation guide for first users
worcs::git_user("your_name", "your_email", overwrite = TRUE)
What's the reason to force overwrite = TRUE rather than the default overwrite = FALSE to not overwrite existing Git credentials?