search

cjvanlissa / worcs

Rstudio project template and convenience functions for the Workflow for Open Reproducible Code in Science (WORCS)
https://cjvanlissa.github.io/worcs/
GNU General Public License v3.0
76 stars 11 forks source link

Fix test and docs for upcoming gert release #96

Closed jeroen closed 3 years ago

jeroen commented 3 years ago

Hi! This fixes a few small issues needed for the upcoming release of gert 1.0. Could you try to get this on CRAN?

cjvanlissa commented 3 years ago

@jeroen will do, this is very kind.

jeroen commented 3 years ago

Awesome, can you let me know when you have submitted the new version to CRAN? Then I'll submit the new gert soon after that.

cjvanlissa commented 3 years ago

@jeroen yes, which gert version number should I require in the DESCRIPTION file?

cjvanlissa commented 3 years ago

Alternatively, this should maintain compatibility with old and new versions, correct?

if("remote" %in% formalArgs(git_remote_add)){
        git_remote_add(remote = "origin", url = remote_repo, repo = path)
      } else {
        git_remote_add(name = "origin", url = remote_repo, repo = path)
      }
jeroen commented 3 years ago

I decided to not change git_remote_add after all, to keep backward compatibility. So this new works should work both with the old and new version of gert.

jeroen commented 3 years ago

Alternatively, this should maintain compatibility with old and new versions, correct?

Yes that works. I confirmed that your current version works with the current and upcoming version of gert.

cjvanlissa commented 3 years ago

@jeroen I'm waiting for one additional contributor to push a change, and will resubmit next Monday latest. Thank you so much for checking reverse compatibility!