search

cjw2021 / QAHOI

Apache License 2.0
47 stars 9 forks source link

parameter --use_nms is not used #3

Closed ilovecv closed 2 years ago

ilovecv commented 2 years ago

Hi,

Thank you very much for sharing the codes. It's great! For the --use_nms parameter defined here https://github.com/cjw2021/QAHOI/blob/main/main.py#L138, it looks like it is not used.

cjw2021 commented 2 years ago

Thanks for your interest in our work. NMS process is used during evaluation. So the --use_nms option is used when the evaluator is initialized. See this line https://github.com/cjw2021/QAHOI/blob/bb7f5fd79e2f33980a41190f9f37460f7c22e67b/engine.py#L119