cjwilburn / dank-memes

A CLI meme generator.

15 stars 14 forks source link

Fix issue where node process hangs after successful dank meme generation. #26

Closed Jaace closed 6 years ago

Jaace commented 6 years ago

Description

Exiting the node process after successful memeing, with messaging. Fix some indentation issues.

Steps to Test

Run the three types of meme generation, ensure that upon completion the command line is back to a standard prompt (not hanging).

Throw up a message to the terminal upon successful exit, similar to the exit messages on error or quitting.

node index.js
node reddit.js
node roulette.js

Checklist

[x] I have tested these code changes and included the relevant urls and screenshots.
[ ] I have updated our build tasks accordingly (if applicable).
[ ] I have updated our documentation accordingly (if applicable).
[ ] I have linted the code that I've included in this PR (if applicable).
[x] My code follows the code style of this project.
[x] My code is ready for review.

Jaace commented 6 years ago

This is ready for review :)