cjwilburn / dank-memes

A CLI meme generator.
15 stars 14 forks source link

Adjust contributors images #34

Closed cjwilburn closed 5 years ago

cjwilburn commented 6 years ago

Summary

Adjust the size of the contributor images in README.md to make them smaller.

Bonus points (and by bonus points, I mean my unending gratitude) if you can find a way to load contributors to the readme dynamically.

trblackw commented 6 years ago

I think I can help you out with this!

cjwilburn commented 6 years ago

Go for it!

trblackw commented 6 years ago

I'm actually a bit confused as to what you're asking for here. I'm assuming you'd be capable of making the images smaller yourself my reducing the height and width attributes. Is there something more specific you're going for? I'd feel silly if I opened a PR with just reduced heights and widths lol.

cjwilburn commented 6 years ago

Yes, I can do this myself, but I am attempting to give folks, especially those new to coding, git, or Github in particular, an opportunity to make a low-stakes contribution to this repo. Feel free to pass this up and let someone else take it on.

trblackw commented 6 years ago

Oh okay! Kind of you. I didn’t catch that. I’ll let someone else take it!

On Wed, Oct 10, 2018 at 2:30 PM Courtney Wilburn notifications@github.com wrote:

Yes, I can do this myself, but I am attempting to give folks, especially those new to coding, git, or Github in particular, an opportunity to make a low-stakes contribution to this repo. Feel free to pass this up and let someone else take it on.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cjwilburn/dank-memes/issues/34#issuecomment-428681623, or mute the thread https://github.com/notifications/unsubscribe-auth/Aiop6ykbno2xRPUhBSj1EhIlRHaTP458ks5ujjzCgaJpZM4XViI9 .

cjwilburn commented 6 years ago

Thanks! I've added the good first issue label so that some first-timers can take a pass at it.

trblackw commented 6 years ago

I’m not exactly a first timer but I still consider myself definitely a beginner when it comes to making pull requests and contributing to open source. Hacktoberfest has motivated me to step my PR game up!

On Wed, Oct 10, 2018 at 2:33 PM Courtney Wilburn notifications@github.com wrote:

Thanks! I've added the good first issue label so that some first-timers can take a pass at it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cjwilburn/dank-memes/issues/34#issuecomment-428682829, or mute the thread https://github.com/notifications/unsubscribe-auth/Aiop6_txpfoUolptsbYwdCi8c-NHtIc0ks5ujj2PgaJpZM4XViI9 .

cjwilburn commented 6 years ago

I'll be writing up some more issues this week, so stay tuned if you want to handle something a little tougher with this repo.

klanti117 commented 6 years ago

would like to pick up this issue

cjwilburn commented 6 years ago

Please pick it up, @klanti117