The index.js, make-meme.js, ron-swanson.js, and roulette.js scripts were returning a promise from opn, which will not resolve until the browser is exited completely. In order to preserve our precious precious tabs and free up our super sweet terminals, the process is now exited right after the meme is generated. 👋
This matches the behavior in dankest-dungeon.js, reddit.js, and yo-dawg.js. 👌
Steps to Test
Run node index.js.
Proceed through prompt (answering yes, selecting options, etc.)
View meme.
Confirm that CLI process has exited even if browser is still open.
Repeat 1 through 4 with make-meme.js, ron-swanson.js, and roulette.js.
Screenshots
N/A
Deploy Notes
N/A
Checklist
[x] I have tested these code changes and included the relevant urls and screenshots.
[ ] I have updated our build tasks accordingly (if applicable).
[ ] I have updated our documentation accordingly (if applicable).
[ ] I have linted the code that I've included in this PR (if applicable).
[x] My code follows the code style of this project.
Description
The
index.js,make-meme.js,ron-swanson.js, androulette.jsscripts were returning a promise fromopn, which will not resolve until the browser is exited completely. In order to preserve our precious precious tabs and free up our super sweet terminals, the process is now exited right after the meme is generated. 👋This matches the behavior in
dankest-dungeon.js,reddit.js, andyo-dawg.js. 👌Steps to Test
node index.js.make-meme.js,ron-swanson.js, androulette.js.Screenshots
N/A
Deploy Notes
N/A
Checklist