search

ck-temp / todo

0 stars 4 forks source link

Implement the basic Button Component #2

Open ck-temp opened 4 years ago

ck-temp commented 4 years ago
  1. Implement the Button component with the basic functionalities.
  2. Acceptance Criteria
    • Button can be customizable to different sizes (small, medium, large).
    • Change the button color and text color.
    • Can have icons in it (right, left, top, bottom).
    • On clicking the button, can able to change the button text to "Loading" or Icon (get from the props)
ck-temp commented 4 years ago

Folks, only after the code changes are merged to 'development' branch this task should be closed. So reopening the issue.

reactgeeks commented 4 years ago

Testcases are in ButtonDemo components you can access it from /button in browser. Added styled component for styling. Added one new functionality of block buttons(full width).

ck-temp commented 4 years ago

@reactgeeks - I could see only demo in the ButtonDemo component, where are the test cases. Can you raise a pull request to development? The folder structure is not correct, create like this - src/todo/components

reactgeeks commented 4 years ago

Added testcases files.

reactgeeks commented 4 years ago

implemented a group button component.

reactgeeks commented 4 years ago

fixed pull request issues and added group button component

reactgeeks commented 4 years ago

cleaned up codes and combined groupbutton and button component.

reactgeeks commented 4 years ago

worked on the suggestion of the button component code.