search

ck2plus / CK2Plus_Rewrite

Home of the complete rewrite of the CK2Plus Mod
16 stars 4 forks source link

Cathar flavor #238

Closed thandley closed 4 years ago

Whizzer commented 4 years ago

Looks pretty god. Nevertheless, a few things: Please file these under a new namespace, for example PlusCathar, starting events from 001, and changing the localisation keys to match existing Plus rewrite entries (see Celtic events among others). Consider using numeric operators added in patch 2.8, removing the need to use needless NOT clauses, and making regular greater-or-equal triggers much more intuitive to read. The conversion events are likely not necessary. For the Celtic Circle of Druids, I found changing some customizable localisation was sufficient. Also, the namespace again. Localisation for traits, events and decisions should go into separate .csv files.

I hope this doesn't discourage you. Feel free to ask for clarification if anything is unclear.

thandley commented 4 years ago

Thanks for the feedback @Whizzer I'll get this fixed and resubmit for review soon!