search

ck86 / gulp-bower-files

Build gulp.src() of your bower packages main files.
80 stars 13 forks source link

Fixed dependency overrides #9

Closed davewasmer closed 10 years ago

davewasmer commented 10 years ago

Packages without bower.json or package.json files were not properly accepting overrides. The lack of either file threw an exception, without checking to see if an override was provided. I added the check, and if an override is provided, a mock empty bower.json structure is returned.

bclozel commented 10 years ago

I'm very interested in this PR. Could we also check for ".bower.json" files first? Those are generated by bower from actual bower.json files or old-format component.json files. This would save a lot of overrides...

ck86 commented 10 years ago

Please remove your copyrights and it would be great if you can add a test for it.

davewasmer commented 10 years ago

@ck86 I made these changes for a project at work, so I can't remove the copyright unfortunately. Test case is on the way.

davewasmer commented 10 years ago

There you are, let me know if it needs anything else.

ck86 commented 10 years ago

I have licensed this plugin under MIT. If you are ok with it when I remove your copyrights then I will merge it.

davewasmer commented 10 years ago

Unfortunately, my company does not allow open source contributions to be licensed MIT. If you aren't okay with dual-licensing this project as MIT / Apache 2.0, I'd suggest closing this PR.

ck86 commented 10 years ago

No sorry.