ckampfe / russ

A TUI RSS reader with vim-like controls and a local-first, offline-first focus
GNU Affero General Public License v3.0
173 stars 18 forks source link

update dependencies, fixes build on android #14

Closed phanirithvij closed 2 years ago

phanirithvij commented 2 years ago
As of now it doesn't build on android (termux) and fails with this error ```python $ cargo install --git https://github.com/ckampfe/russ russ .... Compiling jni v0.19.0 error[E0425]: cannot find value `EXPECTED_JVM_FILENAME` in this scope --> /data/data/com.termux/files/home/.cargo/registry/src/github.com-1ecc6299db9ec823/jni-0.19.0/build.rs:102:25 | 102 | if file_name == EXPECTED_JVM_FILENAME { | ^^^^^^^^^^^^^^^^^^^^^ not found in this scope For more information about this error, try `rustc --explain E0425`. error: could not compile `jni` due to previous error .... ```

Updating the dependency webbrowser to the latest version fixed it.

ckampfe commented 2 years ago

hi @phanirithvij , thank you for the PR. Just curious, are you using Russ on Android? Thank you

phanirithvij commented 2 years ago

If by use you mean regularly, no. I use it on Linux regularly. I tried to build it on termux with the intention of using it and found it works perfectly with these changes. Screenshots Screenshot_2022-11-10-10-48-51-02_84d3000e3f4017145260f7618db1d683 Screenshot_2022-11-10-10-48-30-66_84d3000e3f4017145260f7618db1d683 2022-11-10-104757_1920x1080_scrot Works best with ssh. (There used to be an issue on termux with webbrowser crate but it is fixed now https://github.com/amodm/webbrowser-rs/issues/53#issuecomment-1307173514)

ckampfe commented 2 years ago

@phanirithvij Thank you very much for the contribution and the report about Russ on Android!