search

ckampfe / russ

A TUI RSS reader with vim-like controls and a local-first, offline-first focus
GNU Affero General Public License v3.0
160 stars 18 forks source link

Open link in browser feature #2

Closed Funami580 closed 2 years ago

Funami580 commented 2 years ago

In my opinion a useful feature, what do you think?

ckampfe commented 2 years ago

Hi @Funami580 , thank you for your pull requests. I will try to look at this PR and https://github.com/ckampfe/russ/pull/3 soon. Thank you!

ckampfe commented 2 years ago

Hi again @Funami580, I finally got a chance to look at this, thank you for the PR.

I noticed that the webbrowser library is specified as:

webbrowser = { git = "https://github.com/codota/webbrowser-rs", branch = "feature/add-suppress-output-flag-with-docs" }

which appears to be a fork of the mainline https://crates.io/crates/webbrowser dependency.

What made you use a fork (codota/webbrowser-rs) vs the mainline (amodm/webbrowser-rs)? Also, what is this specific branch? I am not familiar with webbrowser-rs in general, so I would like to understand the context here. Thank you.

Funami580 commented 2 years ago

The problem with the original crate was that it redirected the output of external commands to stdout. This interfered with the russ TUI. See: https://github.com/amodm/webbrowser-rs/issues/20

ckampfe commented 2 years ago

@Funami580 Great, thanks for the explanation. We will have to keep an eye on that functionality in the future to see if the mainline browser crate merges the silent mode PR. Otherwise, this seems good to go, I'm going to merge it. Thanks again for your contribution, I appreciate it.