search

ckampfe / russ

A TUI RSS reader with vim-like controls and a local-first, offline-first focus
GNU Affero General Public License v3.0
173 stars 18 forks source link

Fix doubled key input on Windows, Fixes ckampfe/russ#22 #27

Closed sobharrison closed 5 months ago

sobharrison commented 1 year ago

On Windows all key events would be taken as input including keyup leading to double inputs.

Fixes ckampfe/russ#22 https://github.com/ckampfe/russ/issues/22

sobharrison commented 1 year ago

Note, this change has only been tested on Windows. Needs to be tested on other OSes

ckampfe commented 5 months ago

@sobharrison thank you very much for your contribution. I've tested this on MacOS and it appears to work the same with no regression. I will take your word for it that it works on Windows, as I do not use Russ on Windows myself.

Unfortunately I recently introduced a large refactoring to how Russ handles input, and so this PR conflicts with that. I was able to pull your changes in and commited them here https://github.com/ckampfe/russ/commit/4c3e25931f13276f0c591eac57f6ed0af95fe08f

Again, thank you for the contribution, and I hope this is a satisfactory outcome for your work.