Move to mainline webbrowser, ref #2

ckampfe / russ

A TUI RSS reader with vim-like controls and a local-first, offline-first focus

GNU Affero General Public License v3.0

160 stars 18 forks source link

Closed amodm closed 2 years ago

amodm commented 2 years ago

This PR brings webbrowser back to mainline, with suppressed output being the default behaviour now. See #2 for history.

I've tested this with cargo test as well as basic user interactive testing.

amodm commented 2 years ago

More details about this release v0.6.0, so that you can assess the impact appropriately, are here.

Relevant parts are:

This release makes opening of GUI browsers non-blocking, which should help here as well, in specific corner cases.
Default behaviour is now to suppress stdout/stderr, unless overridden through additional options.

ckampfe commented 2 years ago

Hey @amodm thank you very much for the contribution, I will review ASAP.

ckampfe commented 2 years ago

@amodm This looks good to go, merging it now. Thank you for the contribution as well as your work on webbrowser, I appreciate it!