Don't archive uploaded resources

ckan / ckanext-archiver

Archive CKAN resources

MIT License

21 stars 46 forks source link

Don't archive uploaded resources #37

Closed KrzysztofMadejski closed 7 years ago

KrzysztofMadejski commented 7 years ago

See discussion here https://github.com/ckan/ckanext-archiver/issues/36

I'm just not sure about changing resource.get('resource_type') == 'file.upload' to resource.get('url_type') == 'upload' (https://github.com/DanePubliczneGovPl/ckanext-archiver/commit/9670599ca10fe63f173f2751d67c197ca93a8034#diff-42bd54af067bfafc2cbbae21d83af4b8R389)

It works on mine CKAN 2.3. I believe resource_type can be use freely. Why depend on that?

KrzysztofMadejski commented 7 years ago

For @TkTech I've introduced ckanext-archiver.archive_cloud which defaults to False. That means files uploaded to the platform on cloud storage won't be archived, and won't be qa'ed.

KrzysztofMadejski commented 7 years ago

@davidread this PR is ready to be merged as well. Please check the doubts I have in the first comment.

davidread commented 7 years ago

I'm a bit hazy on resource_type / url_type, so I'll just put it down to a DGU-ism.