QGOV changes - Githubissues

ckan / ckanext-archiver

Archive CKAN resources

MIT License

21 stars 46 forks source link

QGOV changes #81

Open ThrawnCA opened 3 years ago

ThrawnCA commented 3 years ago

Make compatible with Python 3
Use UTC timestamps internally so we don't have conversion problems
Delete obsolete archives
Don't create archival tasks for changes to uploaded files (they get false positives and they don't need to be archived anyway since they're already stored in CKAN)
Integrate with additional Uploader APIs for downloads and metadata if available (see QGOV CKAN fork for details) to enable integration with alternative storage providers such as ckanext-s3filestore
Add Flake8 config
Add Github Actions workflow
Add more tests
Move requirements from setup.py to requirements files

Zharktas commented 3 years ago

Let's remove travis configuration completely, it's not really usable anymore. I'll try to review this soonish.

Zharktas commented 3 years ago

I'll add github action workflow as a separate PR today, so that the action is run for this PR too.

ThrawnCA commented 3 years ago

@Zharktas What was wrong with the Github Workflow in this pull request?

Zharktas commented 3 years ago

The only thing wrong with it, is that it's not run as you have no permissions for this repository. Now that there is a existing workflow, the pull requests will trigger the workflow. And i would like python3 support as separate pull request as python3 support itself does nothing unless CKAN 2.9 is supported as well. There is mine #73, which might do the rest of it once I have time to finish it.

ThrawnCA commented 3 years ago

Well, this is just a merge of all changes in our fork except build config specific to our repos. If you want to split it, feel free.

I've merged master to resolve the conflicts, though.

Zharktas commented 3 years ago

I approved running github action, as it is required for the first time. I'm all in for improving archiver itself, it just might take awhile to get it merged :)