#96 Source Catalog info in transitive harvesting

ckan / ckanext-dcat

CKAN ♥ DCAT

https://docs.ckan.org/projects/ckanext-dcat

165 stars 145 forks source link

#96 Source Catalog info in transitive harvesting #101

Closed etj closed 6 years ago

etj commented 6 years ago

Fix #96

This PR improves #100 (contained here as a squeezed merge):

using asbool() imported from toolkit
cleaned up useless diffs for an easier check
added some doc in the README file.

(dunno how to maintain @cezio as the author of most of the work in git)

amercader commented 6 years ago

@etj We seem to have missed the tests from #100? If you add these (and they pass :) ) I'm happy to merge it.

etj commented 6 years ago

@amercader working on the tests. They weren't passing in #100, so we are fixing them before adding to this PR.

etj commented 6 years ago

@amercader is seems that the tests may fail according to which platform they are run on. I tried to fork this repo, and, without any modification, the travis checks failed. I guess we need a

sudo: required

in the travis settings. Should we open a new issue about this?

etj commented 6 years ago

@amercader code completed, tests added in the PR and are passing. Can you pls review?

amercader commented 6 years ago

Great work @etj, @cezio. Thanks for your contribution and for your patience with the review.