search

ckan / ckanext-dcat

CKAN ♥ DCAT
https://docs.ckan.org/projects/ckanext-dcat
165 stars 145 forks source link

add support for multilingual RDF #124

Open stefina opened 6 years ago

seitenbau-govdata commented 6 years ago

Hi @stefina, we from the German open data portal are also interested in the multilingual support.

Is this the final implementation or is something missing? It seems that the actual change in the pull request changes the type of the expected default value if no value is in the graph to the given predicate. I think therefore some of the unit tests are failing, because the return value is different.

As @amercader mentioned in #55 there is a need to use ckanext-scheming for enabling proper storing of the multilingual fields in the database. A minimal example for the fields title and notes should be could be helpful to get started with it.

stefina commented 6 years ago

@seitenbau-govdata I added some documentation to make it clear how this is used. Would be good to hear your opinion on it. Unfortunately the code-coverage-tests fail since I added documentation. @amercader I think it makes sense to exclude the readme (or *.md-files altogether). What do you think? ;)

seitenbau-govdata commented 6 years ago

@stefina It looks good to me. Maybe a hint would be helpful that the plugin ckanext-scheming is needed to store the values in several languages in the database properly. As I have understand the ckanext-scheming is required then, right?