search

ckan / ckanext-dcat

CKAN ♥ DCAT
163 stars 142 forks source link

Add missing schema.org fields #139

Closed metaodi closed 5 years ago

metaodi commented 5 years ago

This PR adds the following fields:

Additionally a new method additional_fields is added, which makes it easy in a subclass to add their own fields without having to override one of the "internal methods" of the provided SchemaOrgProfile class

metaodi commented 5 years ago

@amercader maybe you can have a look at this. When I was doing an integration lately, I noticed these fields were missing and they IMHO make sense to provide in the basic implementation. And by adding additional_fields we can provide an extension point for everybody, who creates a subclass of SchemaOrgProfile to provide a custom mapping for their schema.

metaodi commented 5 years ago

@amercader do you have feedback for me? Or can you merge this?

amercader commented 5 years ago

This looks good overall @metaodi. The only thing I'm not 100% sold on is using groups as schema.genre. Is there an existing recommendation for using this property for topics, themes, etc

@danbri can you think of a better property?

metaodi commented 5 years ago

@amercader I'm not 100% sure it's correct. But by looking at the example on https://schema.org/genre, where it is used to describe "Late Renaissance" (using the URL http://vocab.getty.edu/aat/300021143), I think it fits pretty good with the CKAN groups. The description of the field on schema.org is "Genre of the creative work, broadcast channel or group", which imho indicates that CKAN groups would be a good match.

amercader commented 5 years ago

@metaodi just revisiting this. I don't see why we can't use multiple SCHEMA.about properties for groups, instead of SCHEMA.genre. The docs say "The subject matter of the content", which I think fits CKAN groups quite well.

If you are happy with this we can merge.

metaodi commented 5 years ago

@amercader SCHEMA.about seems like a good fit, since it's a Thing we can provide a URL and a name/description of the group, thus represent the group even better. I'm currently on vacation, but happy to change that when get to it.

amercader commented 5 years ago

@metaodi I wanted to release a new version while I had some time available so I went ahead and did the change myself (https://github.com/ckan/ckanext-dcat/commit/67c2a5e5b99ac988b36eb466b190b43d4e1b5ab2). Thanks for the PR