search

ckan / ckanext-dcat

CKAN ♥ DCAT
164 stars 142 forks source link

Support JSON-LD catalogs with @graph #159

Closed seitenbau-govdata closed 4 years ago

seitenbau-govdata commented 5 years ago

Adds support for parsing JSON-LD catalogs containing @graph elements.

Links to open issues in rdflib-jsonld relating this problem:

The suggested "solution" is to use rdflib.ConjunctiveGraph() instead of rdflib.Graph().

metaodi commented 4 years ago

@seitenbau-govdata is there any downside in using ConjunctiveGraph? So this should work for all our cases? I see that all tests pass, so I guess everything is fine.

seitenbau-govdata commented 4 years ago

@metaodi We have had the same thoughts. Ultimately we don't know it if something special is not working with the ConjunctiveGraph. So, we have to trust the implemented tests that all relevant use cases are covered.

seitenbau-govdata commented 4 years ago

@metaodi What do you think about the pull request? Maybe it's helpful to have another opinion. @amercader Please let us know your view about the pull request.

metaodi commented 4 years ago

I like it and think it's a good solution. I'd say let's risk it and test in all our installations, if something is broken, we can still revert if needed.

amercader commented 4 years ago

Tests with the alternative JSON-LD syntax seem to pass, so let's merge it

seitenbau-govdata commented 4 years ago

Thanks @metaodi and @amercader !